Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make fs timestamps have millisecond resolution rather than second resolution #3313

Merged
merged 3 commits into from
Dec 10, 2022

Conversation

hoodmane
Copy link
Member

@hoodmane hoodmane commented Dec 2, 2022

Resolves #3311. We can probably remove all the calls to invalidate_caches too...

Upstream PR: emscripten-core/emscripten#18301

Checklists

@ryanking13
Copy link
Member

Thanks, @hoodmane!

We can probably remove all the calls to invalidate_caches too...

IMO, we can still keep invalidate_caches calls if their overhead is negligible (probably we can measure it), as it ensures that the cache is invalidated instead of relying on modification times.

Copy link
Member

@ryanking13 ryanking13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We would need some tests, otherwise LGTM. Thanks!

@hoodmane hoodmane mentioned this pull request Dec 9, 2022
1 task
@rth
Copy link
Member

rth commented Dec 10, 2022

For tests, since it was accepted upstream, I think we can probably merge as is. Just needs a changelog entry.

@hoodmane hoodmane merged commit 8560319 into pyodide:main Dec 10, 2022
@hoodmane hoodmane deleted the tv_nsec branch December 10, 2022 17:50
dcherian added a commit to dcherian/pyodide that referenced this pull request Dec 13, 2022
* main: (45 commits)
  Remove pre-built docker image support (pyodide#3342)
  Remove "Python initialization complete" log line (pyodide#3247)
  Use a more robust method to improve our ModuleNotFound errors (pyodide#3263)
  Distinguish between sync and async JavaScript iterators when possible (pyodide#3339)
  [pre-commit.ci] pre-commit autoupdate (pyodide#3345)
  NFC Place js_flags in separate dict (pyodide#3338)
  NFC Use initialization function to load _pyodide_core (pyodide#3333)
  Make fs timestamps have millisecond resolution rather than second resolution (pyodide#3313)
  Add gensim package pyodide#2545 (pyodide#3326)
  [pre-commit.ci] pre-commit autoupdate (pyodide#3325)
  Update scikit-learn to 1.1.3 (pyodide#3324)
  Fix markdown in doc (pyodide#3323)
  Emscripten 3.1.27 (pyodide#3314)
  [pre-commit.ci] pre-commit autoupdate (pyodide#3254)
  Add a typeshed for the js module (pyodide#3298)
  Unpin host Python patch versions in GHA (pyodide#3309)
  Package pyinstrument (pyodide#3258)
  Add athrow and aclose to JsProxy of an AsyncGenerator (pyodide#3299)
  Add test for MutableMapping methods on object_maps and fix bug (pyodide#3297)
  Bump minimatch from 3.0.4 to 3.1.2 in /src/js (pyodide#3306)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ModuleNotFoundError after writing multiple files with FS.writeFile
3 participants