Add test for MutableMapping methods on object_maps and fix bug #3297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hoodmane
commented
Nov 28, 2022
2 tasks
dcherian
added a commit
to dcherian/pyodide
that referenced
this pull request
Dec 13, 2022
* main: (45 commits) Remove pre-built docker image support (pyodide#3342) Remove "Python initialization complete" log line (pyodide#3247) Use a more robust method to improve our ModuleNotFound errors (pyodide#3263) Distinguish between sync and async JavaScript iterators when possible (pyodide#3339) [pre-commit.ci] pre-commit autoupdate (pyodide#3345) NFC Place js_flags in separate dict (pyodide#3338) NFC Use initialization function to load _pyodide_core (pyodide#3333) Make fs timestamps have millisecond resolution rather than second resolution (pyodide#3313) Add gensim package pyodide#2545 (pyodide#3326) [pre-commit.ci] pre-commit autoupdate (pyodide#3325) Update scikit-learn to 1.1.3 (pyodide#3324) Fix markdown in doc (pyodide#3323) Emscripten 3.1.27 (pyodide#3314) [pre-commit.ci] pre-commit autoupdate (pyodide#3254) Add a typeshed for the js module (pyodide#3298) Unpin host Python patch versions in GHA (pyodide#3309) Package pyinstrument (pyodide#3258) Add athrow and aclose to JsProxy of an AsyncGenerator (pyodide#3299) Add test for MutableMapping methods on object_maps and fix bug (pyodide#3297) Bump minimatch from 3.0.4 to 3.1.2 in /src/js (pyodide#3306) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds tests of all the MutableMapping methods for objects returned by
as_object_map. They all worked but I was accidentally adding only the non mutating methods. I also addedJsMaptopyodide.ffiand fixed it so thatisinstanceworks correctly and mypy agrees with the usage.Checklists