MAINT Use run_in_pyodide in xgboost, opencv, and matplotlib tests #3184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanking13
commented
Oct 14, 2022
hoodmane
added a commit
to pyodide/pytest-pyodide
that referenced
this pull request
Oct 18, 2022
ryanking13 ran into the problem in pyodide/pyodide#3184 (comment) that it's inconvenient to send results from one @run_in_pyodide invocation to another. This adds a mechanism to do so. A SeleniumHandle (perhaps can be named better) can be returned to the host and when passed back into another @run_in_pyodide function one can use it to access the object. This should allow us to make fixtures specifically for use with @run_in_pyodide functions that return one or more SeleniumHandles.
hoodmane
reviewed
Oct 24, 2022
|
Opened a separate PR for test failure unrelated to this: #3202 |
ryanking13
changed the title
ryanking13
commented
Oct 25, 2022
|
|
||
|
|
||
| @matplotlib_test_decorator | ||
| @pytest.mark.xfail( | ||
| reason="TODO: pytest_pyodide.pyodide.JsException: InvalidStateError: An attempt was made to use an object that is not, or is no longer, usable" |
There was a problem hiding this comment.
This test started to fail, I guess it is also related to #3205.
|
The cmdline-runner test failure is not related to this PR. Opened a issue about it (#3207). |
|
Thanks again @hoodmane! PyodideHandle is really cool. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors tests in xgboost, opencv-python, and matplotlib to use
run_in_pyodide. No other things are affected