Fix pypi deploy for patch releases #3113
Conversation
|
Well this still doesn't work. |
|
I think it will work when we release a new version with a tag, as |
|
I don't think the but I get the response: |
|
https://github.com/pyodide/pyodide/actions/runs/3064780993 but I see it was triggered 3 days ago? |
|
That was a manual trigger from the web interface, not from |
| https://api.github.com/repos/${CIRCLE_PROJECT_USERNAME}/${CIRCLE_PROJECT_REPONAME}/dispatches \ | ||
| -d '{"event_type":"deploy-release","client_payload":{}}' | ||
| -H "Authorization: Bearer ${GITHUB_TOKEN}" \ | ||
| https://api.github.com/repos/${CIRCLE_PROJECT_USERNAME}/${CIRCLE_PROJECT_REPONAME}/dispatches/deploy-release \ |
There was a problem hiding this comment.
It seems like the order is different? (+ the filename)
/repos/{owner}/{repo}/actions/workflows/{workflow_id}/dispatches
| https://api.github.com/repos/${CIRCLE_PROJECT_USERNAME}/${CIRCLE_PROJECT_REPONAME}/dispatches/deploy-release \ | |
| https://api.github.com/repos/${CIRCLE_PROJECT_USERNAME}/${CIRCLE_PROJECT_REPONAME}/actions/workflows/deploy_release.yml/dispatches \ |
There was a problem hiding this comment.
Can create an API token and test this out? I tried a bunch of different variations like this and none of them were working for me. But maybe I was just being dumb.
There was a problem hiding this comment.
I removed the type: [deploy-release] part in deploy_release.yml, and I was able to run a workflow with curl.
I think it was blocking a workflow run (it is mentioned in repository_dispatch docs, but probably it was also affecting workflow_dispatch:
When you make a request to create a repository_dispatch event, you must specify an event_type to describe the activity type.
By default, all repository_dispatch activity types trigger a workflow to run.
You can use the types keyword to limit your workflow to run when a specific event_type value is sent in the repository_dispatch webhook payload.
Apparently
repository_dispatchonly works on the main branch and what we need isworkflow_dispatch. After we merge this, we can backport it to stable and I can do an ad-hoc test by trying to use it to deploy pyodide-build v0.21.3.