Use tblib to pickle errors in run_in_pyodide
#2619
Conversation
There was a problem hiding this comment.
Thanks, @hoodmane. It is not directly related to this PR, but I recently found that it is a little non-intuitive that one should build pytest to run a test that uses run_in_pyodide (which is because pytest_assert_rewrites is true in default).
For example,
$ PYODIDE_PACKAGES="some_pkg" make
$ pytest packages/some_pkgwill complain about pytest not being installed, so one has to do
$ PYODIDE_PACKAGES="some_pkg,core" make
# or
$ PYODIDE_PACKAGES="some_pkg,pytest" maketo run a test.
This PR also adds a dependency to run a test, so we probably should update some documentation, or find a better way to deal with inner(?) test dependencies.
|
I should fix it so that if pytest isn't installed it just falls back to not using it. Same is possible for tblib. They just generate better tracebacks when a test fails, so on failure we can append "for a better traceback, build pytest and tblib". |
No description provided.