Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use cmake 3.22 from pip #2489

Merged
merged 5 commits into from
May 4, 2022

Conversation

henryiii
Copy link
Contributor

@henryiii henryiii commented May 4, 2022

Description

See #2486.

@hoodmane
Copy link
Member

hoodmane commented May 4, 2022

Thanks @henryiii! Could you rebuild the docker image and push it to a dockerhub that you control, then update the image tags? Or I can do that and push to this branch if you don't want to.

@henryiii
Copy link
Contributor Author

henryiii commented May 4, 2022

Probably best if you do it, I'll be doing a few quick things, but have to prepare for a bunch of stuff for next week. If you can't get to it in the next few days, I can do it mid next week. (though I am curious to compare the size)

@henryiii
Copy link
Contributor Author

henryiii commented May 4, 2022

The compressed size of the current image is docker manifest inspect pyodide/pyodide-env:20220411-chrome99-firefox98 | jq '.layers[].size' | jq -s 'add' | numfmt --to iec --suffix B => 587MB. New image is 560MB. So it's noticeable, at least. :)

@hoodmane hoodmane merged commit 1093b86 into pyodide:main May 4, 2022
@hoodmane
Copy link
Member

hoodmane commented May 4, 2022

Thanks @henryiii!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants