-
-
Notifications
You must be signed in to change notification settings - Fork 866
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add bump2version #2460
Add bump2version #2460
Conversation
Thanks, @andreysmelter! I have a question. For alpha/dev versions, Python packages and JS packages have different version schemes. For example, we use Can we deal with this in a single command? For example, it would be great if we can do this in a config file: # inside .bumpversion.cfg / setup.cfg
[bumpversion]
current_version = 0.20.1
new_version_python = 0.20.1a1
new_version_js = 0.20.1-alpha.1 |
It might be better to use |
Generally, I like setuptools-scm for Python packages, but I'm not sure that's the best option here. setuptools-scm is not really going to work on non Python files (e.g. run_docker) without significant development where you provide it with some list of lines to replace and how to do that, which is what bump2version does.
So I think keeping things simple with a simple bump2version config is a start (and is already way better than what we had before). Though yes, this means that the alpha versions for the JS package need manual adjustment. If we want to go further later, we can always create a custom Python script calling bump2version in more custom ways. |
Edited the above comment to avoid confusion between the two tools :) |
@rth I can take a look at this next week and continue iterating on this PR. Thanks for the comments and ideas! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, I can confirm this works as expected. I pushed a few extra minor improvements. But yeah anyway one has to look at the git diff and often make manual adjustments before committing/tagging. Still, it's much better than the system we have now.
Merging this as a partial solution, and we can always improve it in follow up MRs (in particular to also do this in the docs with sphinx). Thanks, @andreysmelter !
WIP PR:
Partially addresses issue 2438
by bumping up source code files.
Next steps: