Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update: added missing build==0.7.0 dependency in requirements.txt #2454

Merged
merged 1 commit into from
May 3, 2022
Merged

update: added missing build==0.7.0 dependency in requirements.txt #2454

merged 1 commit into from
May 3, 2022

Conversation

Zyell
Copy link
Contributor

@Zyell Zyell commented May 2, 2022

While building Pyodide and running tests, I came across a missing dependency in the requirements.txt file, so I added the requirement build==0.7.0.

rth
rth approved these changes May 2, 2022
View reviewed changes
Copy link
Member

@rth rth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Zyell !

@rth rth merged commit 6e4a63f into pyodide:main May 3, 2022
@ryanking13
Copy link
Member

Thanks, @Zyell! I'm not sure why build isn't installed during the build because is a dependency of pyodide-build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rth rth rth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Zyell @ryanking13 @rth