Correct PYODIDE_BASE_URL for console.html in CircleCI artifacts #1453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No this still fails due to CORS when loading packages in |
hoodmane
reviewed
Apr 12, 2021
|
Thanks! Even adjusting it so that it breaks with CORS failures would actually be an improvement, currently it loads the most recent version of Pyodide deployed from master without any warning which is pretty confusing. |
Co-authored-by: Hood Chatham <roberthoodchatham@gmail.com>
|
Could you restart the |
|
OK, this this now work https://217-140441556-gh.circle-artifacts.com/0/root/repo/build/console.html ! |
|
Now that this works we should probably add a suggestion somewhere to the dev docs. |
hamlet4401
pushed a commit
to tytgatlieven/pyodide
that referenced
this pull request
Jul 3, 2021
…ide#1453) Co-authored-by: Hood Chatham <roberthoodchatham@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #648
By adjusting PYODIDE_BASE_URL before artifacts are stored in CircleCI but after the workspace has been saved (which is used for S3 deployment), I think we should be able to use console.html from CircleCI artifacts without using local overrides in Chrome #1384 (comment)