Fine tuning of error_handling debug tools #1142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dalcde
reviewed
Jan 16, 2021
hoodmane
force-pushed
the
more-error-handling-fixes
branch
from
6904943 to
34853b4
Compare
dalcde
approved these changes
Jan 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I fixed a typo in
EM_JS_REFandEM_JS_NUM: namelyLOG_EM_JS_ERROR(func_name, err);==>LOG_EM_JS_ERROR(func_name, e);Also added an extra function
log_error_objwhich takes aJsRefand doesconsole.error(jsobj), useful for debugging.