Move call and new to JsMethod #1138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and-new-to-js-method
…over which variant is constructed.
hoodmane
force-pushed
the
call-and-new-to-js-method
branch
from
fa8dc7f to
a4ce376
Compare
|
Should I merge this? |
|
Reviewing the diff just now I caught one minor mistake which I updated. If the diff looks okay to you, I think I'm happy with this. Presumably the plan is still to merge #1126 just before this? |
|
yep |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of this PR is to ensure that
JsProxyis no longer callable, now onlyJsMethodwill be callable. Many bugs were caused by differences in behavior between theJsProxy_CallandJsBoundMethod_Call. If we build a proxy of a callable javascript object, we will use the subclassJsMethod. This way, there is only oneCallmethod and no bugs caused by divergent behaviors.This is on top of #1126 and is required for #1126 to pass the
test_jsproxy_call_kwargstest (the problem in #1126 is that onlyJsProxy_callsupports key word arguments but the object being called is an instance ofJsBoundMethod_call.(Note that #463 makes similar changes to this PR and PR #1126 for similar reasons. Once this is merged, #461 and #463 can be closed.)