MAINT: Small fixes to fail macros #1129
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FAIL_IF_MINUS_ONE
was checking ifarg != 0
, which isFAIL_IF_NONZERO
. I changed that to== -1
as it should be.Also, I added parenthesis guards for the arguments, without them, the macro contains subtle bugs: for example the conditional in
FAIL_IF_MINUS_ONE(1 | 0)
evaluated totrue
even though1 | 0
evaluates to1
which is not equal to -1:Before:
After: