-
-
Notifications
You must be signed in to change notification settings - Fork 866
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIX: Make JsBoundMethod a subclass of JsProxy #1124
Conversation
Ugh yes, there's several closely bound together bugs here. I merged this one into #1126 in order to make the #1126 tests pass (otherwise a bunch of tests fail). Commit 709118c on that branch has everything needed to fix the bug, the stuff on #1126 after that is I merged this, merged master, and messed around with tests. So merge this one first and then I can merge master on that one and then merge that one? Also I have some tests that will only pass once this, #1126, and #1033 all are merged. I guess I can add them to the last one to merge (if I can remember where I put them...). I think between this one and #1033 what should happen is that the Vectorcall implementation in #1033 should be moved to JsBoundMethod, the implementation of So I think the right order is this, then #1126, then I can update #1033 as described and merge that third. |
Also finishing #972 is blocked on this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Generally LGTM, but I'm not the most relevant reviewer for C code.
Please add a changelog entry.
4e98f82
to
8e3161a
Compare
Fixes #788 (tested in
test_nested_attribute_access
) and fixes #1123 (tested intest_window_isnt_super_weird_anymore
). This also resolves a problem that blocks any fix for #768.