-
-
Notifications
You must be signed in to change notification settings - Fork 863
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add _pyodide_core C extension module #1090
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rth
reviewed
Jan 10, 2021
Co-authored-by: Roman Yurchak <rth.yurchak@gmail.com>
rth
approved these changes
Jan 11, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is meant to address two issues:
pyodide_py
needs a most of the stuff fromcore
in order to work, butcore
importspyodide_py
fairly early on in the initialization. Currently it works fine becausepyodide_py
only needscore
to run it's methods not for initialization, but it's easy to make innocuous-seeming changes that mess it up.Instead of directly adding stuff to
pyodide_py
, we make a C module called_core
and add things to this instead. I also added_core.py
which imports names from_core
if we are running in the browser and spits out empty shims otherwise. If needed for testing reasons, these shims can be modified. In_core.py
we can specify which C source file added each object imported from_core
.