-
-
Notifications
You must be signed in to change notification settings - Fork 866
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Separate ns variable in eval_code into globals and locals #1083
Conversation
705216a
to
ec65552
Compare
+1 for this. As a side effect, it replaces the |
Can you add some tests that demonstrate this please? |
Of course =) |
@casatir How's that look for a test? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree it very useful. Please add a changelog entry.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few remaining comments, otherwise LGTM. Thanks.
Also please add a changelog entry.
… on unknown return_mode
I also changed
which would make Jedi more helpful for instance. |
This will allow
pyodide.js
to avoid pollution of global namespace by usingeval_code
with new empty dict.