Enable emjs error handling #1080
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hoodmane
force-pushed
the
enable-emjs-error-handling
branch
from
5e2b536 to
de6acfa
Compare
hoodmane
force-pushed
the
enable-emjs-error-handling
branch
from
de6acfa to
a21e396
Compare
|
@dalcde This most recent failure gave a useful error message where it wouldn't have prior to your conftest work. |
added 3 commits
January 8, 2021 18:25
…, that will catch the error we are trying to throw.
|
WOOHOO Tests pass! =D |
|
I guess these test failures are real: this doesn't work in a webworker in firefox. It does work in chrome or not in a webworker. |
rth
reviewed
Jan 9, 2021
|
@rth I think this can be accepted unless you have any further reservations? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable the error handling set up in #1051.