Workaround for _convert_to_request_dict change #1083
Conversation
ikonst
changed the title
|
Worth noting that #1079 will also fix this particular issue (by relying on less private APIs, but not all) |
|
Thanks for the quick fix. I'd love to get this as a 5.2.2 hotfix rather than waiting to 6.0.0. |
botocore 1.28 changed the signature of private method botocore.client.BaseClient._convert_to_request_dict adding an endpoint_url parameter. We are updating pynamodb to inspect the signature and add this parameter as needed.
In #1083 we've started passing an `endpoint_url` parameter to _convert_to_request_dict due to changes made in botocore 1.28. When a model does not specify a `host`, the `endpoint_url` would be `None`. To determine the actual `endpoint_url` in botocore ≥1.28, we must call another private method, `_resolve_endpoint_ruleset`.
In #1083 we've started passing an `endpoint_url` parameter to _convert_to_request_dict due to changes made in botocore 1.28. When a model does not specify a `host`, the `endpoint_url` would be `None`. To determine the actual `endpoint_url` in botocore ≥1.28, we must call another private method, `_resolve_endpoint_ruleset`.
In #1083 we've started passing an `endpoint_url` parameter to _convert_to_request_dict due to changes made in botocore 1.28. When a model does not specify a `host`, the `endpoint_url` would be `None`. To determine the actual `endpoint_url` in botocore ≥1.28, we must call another private method, `_resolve_endpoint_ruleset`.
|
Would love to see this backported to 4.x as a 4.3.4 release. |
As a side note, 5.2.3 fixes compatibility with python-botocore >= 1.28.0 [1] [1] pynamodb/PynamoDB#1083 git-svn-id: file:///srv/repos/svn-community/svn@1345925 9fca08f4-af9d-4005-b8df-a31f2cc04f65
As a side note, 5.2.3 fixes compatibility with python-botocore >= 1.28.0 [1] [1] pynamodb/PynamoDB#1083 git-svn-id: file:///srv/repos/svn-community/svn@1345925 9fca08f4-af9d-4005-b8df-a31f2cc04f65
botocore 1.28 changed the signature of private method botocore.client.BaseClient._convert_to_request_dict adding an endpoint_url parameter. We are updating pynamodb to inspect the signature and add this parameter as needed.
botocore 1.28 changed the signature of private method botocore.client.BaseClient._convert_to_request_dict adding an endpoint_url parameter. We are updating pynamodb to inspect the signature and add this parameter as needed.
botocore 1.28 changed the signature of private method botocore.client.BaseClient._convert_to_request_dict adding an endpoint_url parameter. We are updating pynamodb to inspect the signature and add this parameter as needed.
botocore 1.28 changed the signature of private method botocore.client.BaseClient._convert_to_request_dict adding an endpoint_url parameter. We are updating pynamodb to inspect the signature and add this parameter as needed.
botocore 1.28 changed the signature of private method botocore.client.BaseClient._convert_to_request_dict adding an endpoint_url parameter. We are updating pynamodb to inspect the signature and add this parameter as needed.
botocore 1.28 changed the signature of private method botocore.client.BaseClient._convert_to_request_dict adding an endpoint_url parameter. We are updating pynamodb to inspect the signature and add this parameter as needed.
|
4.x backport should be available at https://pypi.org/project/pynamodb/4.4.0/ |
|
@ikonst I am getting this error |
I had the same issue with one lambda containerized. I used aws public image for the lambda with the tag Also, if you do install requirements in this container, make sure you use target in the command |
|
Are you suggesting that recent pynamodb doesn't work well with old botocore 1.20? |
@dobeerman I am using lambda containerization with this image |
Thanks a lot. This fixed my bug. |
botocore 1.28 changed the signature of private method botocore.client.BaseClient._convert_to_request_dict adding an endpoint_url parameter. We are updating pynamodb to inspect the signature and add this parameter as needed.
botocore 1.28 changed the signature of private method
botocore.client.BaseClient._convert_to_request_dictadding anendpoint_urlparameter. We are updating pynamodb to inspect the signature and add this parameter as needed.P.S. we would probably need to backport this to 5.x.