Vueify display show and snatch selection #4888
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Theres still allot of mako templating in it. Any reason why where not removing those? |
|
Yes, this leads to another branch I have locally. I'll be moving more of it over there. I need the helpers I added in this for yet other branch. |
OmgImAlexis
changed the title
…the refresh button. Also it only reloads the page, which we can do also directly. * Removed api import. As it's not used.
p0psicles
approved these changes
Aug 11, 2018
38 tasks
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
showto Vue object so we can start using it on that page as well as some helpers. I've also moved the snatch selection over the Vue as need that done to convertshowheader.makoto a component.