Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove /ui/ route, add fallback 404/500 #4565

Merged
merged 3 commits into from
Jul 5, 2018
Merged

Remove /ui/ route, add fallback 404/500 #4565

merged 3 commits into from
Jul 5, 2018

Conversation

sharkykh
Copy link
Contributor

@sharkykh sharkykh commented Jul 5, 2018

  • /ui is no longer used (not to be confused with /ws/ui.
  • Add 404/500 fallback routes for Vue error pages (500 error isn't on the router yet)

@sharkykh sharkykh added this to the 0.2.7 milestone Jul 5, 2018
OmgImAlexis
OmgImAlexis previously approved these changes Jul 5, 2018
View reviewed changes
@sharkykh sharkykh force-pushed the feature/ui-backend branch from 172db6f to b903839 Compare July 5, 2018 11:57
@sharkykh
Copy link
Contributor Author

sharkykh commented Jul 5, 2018

Rebased.

@OmgImAlexis OmgImAlexis merged commit 5fb7d34 into develop Jul 5, 2018
@OmgImAlexis OmgImAlexis deleted the feature/ui-backend branch July 5, 2018 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OmgImAlexis OmgImAlexis OmgImAlexis approved these changes

Assignees
No one assigned
Labels
Concluded Enhancement
Projects
None yet
Milestone
0.2.7
Development

Successfully merging this pull request may close these issues.
2 participants
@sharkykh @OmgImAlexis