Vueify header #4519
Vueify header #4519
Conversation
sharkykh
force-pushed
the
vueify/header
branch
3 times, most recently
from
23ca22c to
816bc8b
Compare
sharkykh
force-pushed
the
vueify/header
branch
4 times, most recently
from
a4f5edc to
23fd509
Compare
| return { | ||
| // Python conversions | ||
| <% has_emby_api_key = json.dumps(app.EMBY_APIKEY != '') %> | ||
| hasEmbyApiKey: ${has_emby_api_key}, |
There was a problem hiding this comment.
@OmgImAlexis
I think this the last blocker to finishing this component (and maybe moving to .vue file).
I can't add the API key to the endpoint (#4404), and we never decided on a solution for the passwords / API keys.
There was a problem hiding this comment.
We should allow PATCH for them for now. I'm really not okay with sending the API keys and passwords back to the client if we don't have to.
There was a problem hiding this comment.
Here I need to know if the API key is set, not patch it.
So what I'm saying is, there was a discussion on Slack about how to handle situations where you need to know if it's set (excluding the config pages where we currently have the value in the HTML).
That discussion never reached its conclusion - so we need to figure it out.
I've decided to just remove the emby API key check for now, just so I can move forward with this.
Left a comment in place though.
There was a problem hiding this comment.
Why is the value needed? We may be able to work around this in another way.
sharkykh
added
Needs test (Vue)
It was needed to ensure the button to update Emby was only visible if you had all the settings set ( |
sharkykh
force-pushed
the
vueify/header
branch
2 times, most recently
from
a73c360 to
e2eaacc
Compare
| @@ -88,19 +87,13 @@ def __init__(self, rh, filename): | |||
| 'sbDefaultPage': app.DEFAULT_PAGE, | |||
| 'loggedIn': rh.get_current_user(), | |||
| 'sbStartTime': rh.startTime, | |||
| 'numErrors': len(classes.ErrorViewer.errors), | |||
| 'numWarnings': len(classes.WarningViewer.errors), | |||
| 'sbPID': str(app.PID), | |||
There was a problem hiding this comment.
Can this be removed too?
There was a problem hiding this comment.
No, it's still being used everywhere.
- Move javascript to component - Fix dropdown hover not firing - Fix having to click twice on nav with dropdown (old bug) - Fix restart and shutdown confirmation dialogs - Add logout confirmation dialog
|
|
partials/header.makoto a Vue component(as much as possible)topmenuarguments 🎉I still need to add some values to the API, and hopefully remove all the Python conversions.