Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add more fields to config including patch #4404

Merged
merged 11 commits into from
Jun 25, 2018
Merged

add more fields to config including patch #4404

merged 11 commits into from
Jun 25, 2018

Conversation

OmgImAlexis
Copy link
Collaborator

@sharkykh @p0psicles

From Slack:

OmgImAlexis [10:30]
I want to remove some of the fields from the API such as PLEX_SERVER_PASSWORD and other API keys, etc. I'm thinking instead we return a boolean depending on if it's set or not?

@OmgImAlexis OmgImAlexis added this to the 0.2.6 milestone Jun 18, 2018
@OmgImAlexis OmgImAlexis requested a review from sharkykh June 18, 2018 01:20
sharkykh
sharkykh previously requested changes Jun 18, 2018
View reviewed changes
medusa/server/api/v2/config.py Outdated
'torrents.verifySSL': BooleanField(app, 'TORRENT_VERIFY_CERT'),
'nzb.enabled': BooleanField(app, 'USE_NZBS'),
'nzb.username': StringField(app, 'NZBGET_USERNAME'),
'nzb.password': StringField(app, 'NZBGET_PASSWORD'),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These two should be removed (duplicates of 'nzb.nzbget.username' and 'nzb.nzbget.password')

medusa/server/api/v2/config.py Outdated
section_data['torrents']['seedTime'] = app.TORRENT_SEED_TIME
section_data['torrents']['username'] = app.TORRENT_USERNAME
section_data['torrents']['verifySSL'] = bool(app.TORRENT_VERIFY_CERT)

section_data['nzb'] = NonEmptyDict()
section_data['nzb']['enabled'] = bool(app.USE_NZBS)
section_data['nzb']['username'] = app.NZBGET_USERNAME
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same, duplicate of: section_data['nzb']['nzbget']['username']

medusa/server/api/v2/config.py Outdated
# app.NZBGET_CATEGORY_ANIME_BACKLOG
section_data['nzb']['host'] = app.NZBGET_HOST
section_data['nzb']['priority'] = app.NZBGET_PRIORITY
# section_data['nzb']['password'] = app.NZBGET_PASSWORD
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Duplicate of section_data['nzb']['nzbget']['password']

themes-default/slim/static/js/store.js Outdated
method: null,
paused: null,
rpcurl: null,
seedTime: null,
verifySSL: null
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems to be missing the username property

themes-default/slim/static/js/store.js Outdated
categoryBacklog: null,
categoryAnimeBacklog: null
},
username: null
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need for this property

themes-default/slim/static/js/store.js Outdated
priority: null,
useHttps: null,
username: null
},
password: null,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need for this property.

themes-default/slim/static/js/store.js Outdated
forced: null,
categoryAnime: null,
categoryBacklog: null,
categoryAnimeBacklog: null
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to be missing:

username
host

@OmgImAlexis

This comment has been minimized.

Sign in to view
p0psicles
p0psicles previously requested changes Jun 25, 2018
View reviewed changes
dredd/api-description.yml Outdated
@@ -1278,8 +1278,8 @@ definitions:
type: string
host:
type: string
password:
type: string
# password:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you need to keep these commented?

medusa/server/api/v2/config.py Outdated
section_data['kodi']['update']['onlyFirst'] = bool(app.KODI_UPDATE_ONLYFIRST)
section_data['kodi']['host'] = app.KODI_HOST
section_data['kodi']['username'] = app.KODI_USERNAME
# section_data['kodi']['password'] = app.KODI_PASSWORD
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Imo we can leave these out.
Can you remove it, in stead of commenting?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't mind leaving out the passwords. But then please remove the commented lines.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left the comments I could find out if we needed them removed or not.

@OmgImAlexis OmgImAlexis merged commit a4d2063 into develop Jun 25, 2018
@OmgImAlexis OmgImAlexis deleted the more-config-fields branch June 25, 2018 11:15
@sharkykh sharkykh mentioned this pull request Jul 7, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@p0psicles p0psicles p0psicles approved these changes

@sharkykh sharkykh sharkykh left review comments

Assignees
No one assigned
Labels
Concluded Enhancement
Projects
None yet
Milestone
0.2.6
Development

Successfully merging this pull request may close these issues.
3 participants
@OmgImAlexis @p0psicles @sharkykh