[Feature] Show floating notification badge in small views #3921
Conversation
Show a floating notification badge (for errors / warnings / news) on the navbar toggle button in when using small views such as mobile.
Codecov Report
@@ Coverage Diff @@
## develop #3921 +/- ##
===========================================
- Coverage 29.37% 29.37% -0.01%
===========================================
Files 274 274
Lines 35420 35421 +1
===========================================
Hits 10405 10405
- Misses 25015 25016 +1
Continue to review full report at Codecov.
|
| @@ -111,6 +111,7 @@ def __init__(self, rh, filename): | |||
| 'newsBadge': '', | |||
| 'toolsBadge': '', | |||
| 'toolsBadgeClass': '', | |||
| 'floatingMenuBadge': '', | |||
There was a problem hiding this comment.
No new python vars please. This should be implemented client side.
There was a problem hiding this comment.
Do you mean 'reading' the badge info from the tools badge and recreating it?
There was a problem hiding this comment.
I should be more specific - most all of the info needed to create a badge with the correct color is only server side (apart from the unread news count which is global (app.UNREAD_NEWS).
There was a problem hiding this comment.
I mean there should be no changes to the python code for any new ui changes. Everything should now be done client side. The badges and HTML that're currently handled server side like the ones above will all be removed very soon.
| @@ -2843,6 +2843,20 @@ select, | |||
| padding: 0; | |||
| } | |||
|
|
|||
| .floating-badge { | |||
There was a problem hiding this comment.
No updating legacy please.
Just a small QoL thing...
Show a floating notification badge (for errors / warnings / news) on the navbar toggle button in when using small views such as mobile.