Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move tests/ to project root #361

Merged
merged 3 commits into from
Jul 19, 2024
Merged

Conversation

jessegrabowski
Copy link
Member

Closes #351

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@ricardoV94 ricardoV94 requested a review from maresb July 18, 2024 06:13
@maresb
Copy link
Collaborator

maresb commented Jul 18, 2024

The branch is all screwed up, but I like the proposal.

@jessegrabowski
Copy link
Member Author

I'm not sure why it's showing merge conflicts. Rebasing my local branch onto main does nothing, so things should be aligned?

@maresb
Copy link
Collaborator

maresb commented Jul 18, 2024

Hmm, does git fetch upstream main:main pull anything for you?

@jessegrabowski
Copy link
Member Author

I just updated main, did git reset --hard origin/main on my branch, force pushed, then moved the test files and committed. This was my nuclear attack; I am officially defeated by these merge conflicts.

@jessegrabowski
Copy link
Member Author

Also I can locally merge my branch into main without conflicts. So I'm really stumped.

@jessegrabowski
Copy link
Member Author

The only way nuclear attack can fail is if you don't attack enough.

Copy link
Collaborator

@maresb maresb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@jessegrabowski
Copy link
Member Author

Do you know why the old CI runners haven't gone away? I edited .github/tests.yml to point to the right place

@maresb
Copy link
Collaborator

maresb commented Jul 19, 2024

Ah. I think it's the way the tests are referenced in the branch rules. Probably @ricardoV94 will need to remove and readd the required tests due to the label change.

@ricardoV94
Copy link
Member

Ah. I think it's the way the tests are referenced in the branch rules. Probably @ricardoV94 will need to remove and readd the required tests due to the label change.

Right, I'll do that

@ricardoV94 ricardoV94 merged commit 99170df into pymc-devs:main Jul 19, 2024
8 checks passed
@ricardoV94
Copy link
Member

Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move tests to project root
3 participants