-
-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move tests/
to project root
#361
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
The branch is all screwed up, but I like the proposal. |
I'm not sure why it's showing merge conflicts. Rebasing my local branch onto main does nothing, so things should be aligned? |
Hmm, does |
d222e4c
to
140ac96
Compare
140ac96
to
51704bd
Compare
I just updated main, did |
Also I can locally merge my branch into main without conflicts. So I'm really stumped. |
4cd007c
to
4c59d53
Compare
The only way nuclear attack can fail is if you don't attack enough. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
Do you know why the old CI runners haven't gone away? I edited |
Ah. I think it's the way the tests are referenced in the branch rules. Probably @ricardoV94 will need to remove and readd the required tests due to the label change. |
Right, I'll do that |
Done |
Closes #351