Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check execution order #97

Merged
merged 1 commit into from
Apr 4, 2021

Conversation

MarcoGorelli
Copy link
Contributor

@MarcoGorelli MarcoGorelli commented Apr 4, 2021

Description

Following up on a suggestion by @OriolAbril :

How difficult would it be to add a pre-commit check that ensures notebooks have been executed sequentially? Or an extra ci check with another tool?

Indeed, there are some notebooks which have cells which are out-of-order! So, for the time being, am excluding them from the check, then they can be re-run and put back in to the check later

Copy link
Member

@OriolAbril OriolAbril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@OriolAbril OriolAbril merged commit a4b0dae into pymc-devs:main Apr 4, 2021
@MarcoGorelli MarcoGorelli deleted the check-execution-order branch April 4, 2021 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants