Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎈 Updated notebook to use numpy Generator #92

Merged
merged 1 commit into from
Apr 2, 2021
Merged

🎈 Updated notebook to use numpy Generator #92

merged 1 commit into from
Apr 2, 2021

Conversation

larryshamalama
Copy link
Member

In light of the Google Summer of Code requirement to submit a pull request, here is my attempt at a two-line change in which I use numpy Generator.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@larryshamalama larryshamalama mentioned this pull request Mar 31, 2021
Closed
Copy link
Member

@OriolAbril OriolAbril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, thanks for the PR

@OriolAbril OriolAbril requested a review from twiecki March 31, 2021 21:11
@OriolAbril
Copy link
Member

Once merged I will move the tracker issue to "Best Practices" 😄

@OriolAbril OriolAbril merged commit 2cb046f into pymc-devs:main Apr 2, 2021
twiecki pushed a commit that referenced this pull request Jan 17, 2023
* Make xhistogram dependency optional

* Update setup.py

* Update setup.py

Co-authored-by: Ricardo Vieira <28983449+ricardoV94@users.noreply.github.com>

* Update setup.py

* Update setup.py

* pretty extras require

* Update setup.py

Co-authored-by: Ricardo Vieira <28983449+ricardoV94@users.noreply.github.com>

* fix black

Co-authored-by: Maxim Kochurov <maxim.v.kochurov@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants