Fix Minibatch alignment in Bayesian Neural Network example + Pre-commit hooks #719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
wiwa
changed the title
fonnesbeck
reviewed
Nov 16, 2024
| @@ -190,7 +190,7 @@ | |||
| }, | |||
There was a problem hiding this comment.
Line #21. ann_input = pm.Data("ann_input", minibatch_x, mutable=True, dims=("obs_id", "train_cols"))
mutability is True by default
Reply via ReviewNB
There was a problem hiding this comment.
Changing this would also change a bunch of stuff in the diff -- we'd have to re-execute the notebook, otherwise "Check cells were executed sequentially" would fail during pre-commit. Since this PR is just running the pre-commit hook for someone else's (seemingly-abandoned) PR, I'd prefer to just leave it if it's fine.
fonnesbeck
approved these changes
Nov 16, 2024
fonnesbeck
pushed a commit
to fonnesbeck/pymc-examples
that referenced
this pull request
Dec 20, 2024
…it hooks (pymc-devs#719) * Fix Minibatch alignment in Bayesian Neural Network example * Run: pre-commit run all-files --------- Co-authored-by: Deepak CH <deepak.23BCS10092@ms.sst.scaler.com>
fonnesbeck
pushed a commit
to fonnesbeck/pymc-examples
that referenced
this pull request
Dec 20, 2024
…it hooks (pymc-devs#719) * Fix Minibatch alignment in Bayesian Neural Network example * Run: pre-commit run all-files --------- Co-authored-by: Deepak CH <deepak.23BCS10092@ms.sst.scaler.com>
fonnesbeck
pushed a commit
to fonnesbeck/pymc-examples
that referenced
this pull request
Dec 20, 2024
…it hooks (pymc-devs#719) * Fix Minibatch alignment in Bayesian Neural Network example * Run: pre-commit run all-files --------- Co-authored-by: Deepak CH <deepak.23BCS10092@ms.sst.scaler.com>
fonnesbeck
pushed a commit
to fonnesbeck/pymc-examples
that referenced
this pull request
Dec 20, 2024
…it hooks (pymc-devs#719) * Fix Minibatch alignment in Bayesian Neural Network example * Run: pre-commit run all-files --------- Co-authored-by: Deepak CH <deepak.23BCS10092@ms.sst.scaler.com>
fonnesbeck
pushed a commit
to fonnesbeck/pymc-examples
that referenced
this pull request
Dec 23, 2024
…it hooks (pymc-devs#719) * Fix Minibatch alignment in Bayesian Neural Network example * Run: pre-commit run all-files --------- Co-authored-by: Deepak CH <deepak.23BCS10092@ms.sst.scaler.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix Minibatch Alignment in Bayesian Neural Network Example + Pre-commit hooks
Issue
Fixes #654.
Changes Made
pre-commit run --all-fileson Fix Minibatch alignment in Bayesian Neural Network example #689