Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GP-Smoothing Notebook to V5 #603

Merged
merged 2 commits into from
Nov 17, 2023
Merged

Conversation

juanitorduz
Copy link
Collaborator

@juanitorduz juanitorduz commented Nov 17, 2023

Update to V5


📚 Documentation preview 📚: https://pymc-examples--603.org.readthedocs.build/en/603/

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@juanitorduz juanitorduz requested a review from twiecki November 17, 2023 22:16
@twiecki
Copy link
Member

twiecki commented Nov 17, 2023

Weird NB, doesn't even use the GP submodule. Should we even keep it around?

@juanitorduz
Copy link
Collaborator Author

Weird NB, doesn't even use the GP submodule. Should we even keep it around?

Indeed! It is using GaussianRandomWalk to smooth the data. It is interesting but I am not sure if important enough to keep it. I do not have strong opinions. (It was more of a low hanging fruit)

@twiecki
Copy link
Member

twiecki commented Nov 17, 2023

Let's delete it.

@twiecki twiecki merged commit 27e6481 into pymc-devs:main Nov 17, 2023
1 check passed
@twiecki
Copy link
Member

twiecki commented Nov 17, 2023

Still merging so we have the latest in the history.

@juanitorduz juanitorduz deleted the gp-smoothing-v5 branch November 17, 2023 23:00
alporter08 pushed a commit to alporter08/pymc-examples that referenced this pull request Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants