Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nb: rolling-regression; add footer #434

Merged
merged 5 commits into from
Oct 8, 2022

Conversation

reshamas
Copy link
Contributor

@reshamas reshamas commented Oct 7, 2022

References

Notes for the Reviewer

None

#DataUmbrellaPyMCSprint

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@review-notebook-app
Copy link

review-notebook-app bot commented Oct 7, 2022

View / edit / reply to this conversation on ReviewNB

twiecki commented on 2022-10-07T12:38:20Z
----------------------------------------------------------------

can you change: pm.GaussianRandomWalk("beta", sigma=sigma_beta, dims="time") and add

init_dist=pm.Normal.dist(0, 10) as a kwarg. This is required for both GaussianRandomWalk distributions.

pm.GaussianRandomWalk("beta", sigma=sigma_beta, init_dist=pm.Normal.dist(0, 10), dims="time")


@reshamas reshamas requested a review from twiecki October 7, 2022 20:29
@twiecki twiecki merged commit 84110d6 into pymc-devs:main Oct 8, 2022
@twiecki
Copy link
Member

twiecki commented Oct 8, 2022

Thanks @reshamas!

@reshamas reshamas deleted the nb-rolling-regression branch October 8, 2022 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants