Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notebook: GLM-hierarchical updates (styling, fixing links, etc) #427

Merged
merged 4 commits into from
Sep 30, 2022

Conversation

reshamas
Copy link
Contributor

Description

References

Notes for the Reviewer

  • Check that the notebook tags are appropriate
  • 3 screenshots are missing, and I wasn't sure where to find them.
  • This text refers to Chris F's multilevel notebook. However, it does not seem a good practice to refer to a cell number in another notebook, as it could easily change:

Critically, many effects that look quite large and significant in the non-hiearchical model actually turn out to be much smaller when we take the group distribution into account (this point can also well be seen in plot In[12] in Chris Fonnesbeck's notebook {ref}multilevel_modeling. Shrinkage can thus be viewed as a form of smart regularization that helps reduce false-positives!

#DataUmbrellaPyMCSprint

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@reshamas reshamas requested a review from twiecki September 30, 2022 19:49
@twiecki twiecki merged commit b84c42e into pymc-devs:main Sep 30, 2022
@twiecki
Copy link
Member

twiecki commented Sep 30, 2022

Thanks @reshamas!

@reshamas reshamas deleted the nb_glm_hierarchical branch October 8, 2022 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants