-
-
Notifications
You must be signed in to change notification settings - Fork 253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add core notebooks as cards to example gallery #415
Conversation
Looks good. Although just a few thoughts:
|
that would be good but I don't know how to do it. The differences are because the core notebooks use grids and cards provided by sphinx-design whereas the regular ones use the style provided by sphinx gallery.
would moving the note below the core notebooks grid solve or partially solve this? |
I think it would improve things. Maybe good to get someone else's view on it as well to see if we need it at all. Just a random thought... could we get more consistency by placing all the notebooks in pymc-examples and just pointing to them from the main docs? |
We decided to have a handful of notebooks in the pymc repo to make sure there are always some notebooks that are up to date with the latest release. pymc-examples is too big of a collection and with too little contributions and reviews available to keep the notebooks up to date. From what I have seen, even with some nb update pushes around pymc releases and the like, at least ~50% of the notebooks are consistently 2+ years old. |
93e64d6
to
746c401
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Would be great to figure out how to get the same kind of grid formatting for all the notebooks in the future.
closes #379