Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add header and footers for hierarchical partial pooling #393

Merged
merged 8 commits into from
Jul 22, 2022
Merged

Add header and footers for hierarchical partial pooling #393

merged 8 commits into from
Jul 22, 2022

Conversation

azihna
Copy link
Contributor

@azihna azihna commented Jul 9, 2022

References

Towards #56

Description

Added header and footer to the file similar to the Jupyter Style Guide.

@PrinceAsiedu

CC:@reshamas
#DataUmbrellaPyMCSprint

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@OriolAbril
Copy link
Member

The notebook_title comment is particularly critical. But I am not making a request changes review because I might not be able to review again and approve before it os fixed and merged

@reshamas
Copy link
Contributor

@azihna
I found some history of the authorship of the notebook here:
https://github.com/pymc-devs/pymc/pulls?q=is%3Apr+is%3Aclosed+pooling

Looks like it is:

cc: @OriolAbril

@cluhmann
Copy link
Member

Yup, I think the authorship section is all I see that's left to add. Original authors and 2 updates (Adrian's and this one).

@aloctavodia
Copy link
Member

Hi @azihna thanks for your contribution, the only thing still missing is the authorship section. Let us know if you need further assistance.

@reshamas reshamas mentioned this pull request Jul 21, 2022
Open
16 tasks
@azihna
Copy link
Contributor Author

azihna commented Jul 22, 2022

Thanks for the reviews, everyone. Also added the author section after the post from @reshamas

@aloctavodia aloctavodia merged commit c90e91e into pymc-devs:main Jul 22, 2022
@cluhmann
Copy link
Member

This looks good to me!

kuvychko pushed a commit to kuvychko/pymc-examples that referenced this pull request Oct 20, 2022
@azihna @kuvychko
Add header and footers for hierarchical partial pooling (pymc-devs#393)
074adf6 
* Fix start and end of the files

* Fix start and end for ipynb

* Fix start and end for ipynb

* Fix start and end for ipynb

* Fix notebook name and watermark

* Pass pre-commit

* Add authorship

* Pre-commit checks

Co-authored-by: Alihan Zihna <a.zihna@ckhgbdp.onmicrosoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OriolAbril OriolAbril OriolAbril left review comments

@twiecki twiecki twiecki approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@azihna @OriolAbril @reshamas @cluhmann @aloctavodia @twiecki