Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bayesian A/B Testing Introduction - Apply best practices #383

Merged
merged 7 commits into from
Sep 21, 2022
Merged

Bayesian A/B Testing Introduction - Apply best practices #383

merged 7 commits into from
Sep 21, 2022

Conversation

tcuongd
Copy link

@tcuongd tcuongd commented Jun 26, 2022 •
edited
Loading

  • Update notebook to follow style guide, addresses Bayesian A/B testing #172
  • Rename notebook to bayesian_ab_testing_introduction.ipynb, to make its purpose clear compared to future notebooks about Bayesian A/B testing.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@OriolAbril
Copy link
Member

There is a math related rendering issue in https://pymcio--383.org.readthedocs.build/projects/examples/en/383/case_studies/bayesian_ab_testing_introduction.html#value-conversions after the first code blocks.

OriolAbril
OriolAbril reviewed Jul 11, 2022
View reviewed changes
examples/references.bib Outdated Show resolved Hide resolved
@OriolAbril
Copy link
Member

Thanks for the PR and sorry for ths slowness in reviewing

@tcuongd
Copy link
Author

tcuongd commented Sep 10, 2022

Hmm this is the error when building the docs on CI:

  File "/home/docs/checkouts/readthedocs.org/user_builds/pymc-examples/envs/383/lib/python3.8/site-packages/myst_nb/core/render.py", line 626, in render_image
    data_bytes = a2b_base64(data.content)
binascii.Error: Incorrect padding

Have you seen this before?

@OriolAbril
Copy link
Member

Sorry, the PR slipped through the cracks. I haven't seen that before. Can you try rebasing and see if the same error persists?

@tcuongd tcuongd requested a review from OriolAbril September 21, 2022 14:54
@OriolAbril OriolAbril merged commit aa1ee22 into pymc-devs:main Sep 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OriolAbril OriolAbril OriolAbril approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tcuongd @OriolAbril