Check out this pull request on 

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

Looks like some myst problem? Make sure your code is black and then try to remove the myst file so that it will get regenerated during pre-commit.

View / edit / reply to this conversation on ReviewNB

cfonnesbeck commented on 2022-06-04T14:41:04Z
----------------------------------------------------------------

Please remove the pymc objects from the tags, and just keep the first three that are descriptive of the notebook.

cuchoi commented on 2022-06-04T15:13:13Z
----------------------------------------------------------------

Done

View / edit / reply to this conversation on ReviewNB

cfonnesbeck commented on 2022-06-04T14:41:05Z
----------------------------------------------------------------

Since there is a watermark the print statement can be removed

cuchoi commented on 2022-06-04T15:13:20Z
----------------------------------------------------------------

Done

View / edit / reply to this conversation on ReviewNB

cfonnesbeck commented on 2022-06-04T14:41:05Z
----------------------------------------------------------------

If you'd like to hide these user warnings, you could add the following to the import cell:

import warnings
warnings.filterwarnings(
    action='ignore',
    category=UserWarning
)

cuchoi commented on 2022-06-04T15:13:28Z
----------------------------------------------------------------

Done

Done

View entire conversation on ReviewNB

View / edit / reply to this conversation on ReviewNB

twiecki commented on 2022-06-04T16:56:15Z
----------------------------------------------------------------

Can you instead import aesara.tensor as at and use pm.math functions where available (e.g. for exp())?

cuchoi commented on 2022-06-04T21:55:08Z
----------------------------------------------------------------

Updated the import for the sample code. Also updated at.concatenate to pm.math.concatenate and at.exp to pm.math.exp. Didn't find a pm.math equivalent for at.extra_ops.diff.

View / edit / reply to this conversation on ReviewNB

OriolAbril commented on 2022-06-04T19:27:10Z
----------------------------------------------------------------

I'd just remove this. The output is no longer a dict but InferenceData and in general I think examples should focus on using it, not explaining what it is (with the exception of some notebooks we might want to dedicate to this).

cuchoi commented on 2022-06-04T21:56:32Z
----------------------------------------------------------------

Updated the text to remove the explanation.

View / edit / reply to this conversation on ReviewNB

OriolAbril commented on 2022-06-04T19:27:11Z
----------------------------------------------------------------

aesara is imported and already appears on the watermark, so it is not necessary to pass it manually to the watermark call to have it included. aeppl should be added there though

cuchoi commented on 2022-06-04T21:56:02Z
----------------------------------------------------------------

Done

Updated the import for the sample code. Also updated at.concatenate to pm.math.concatenate and at.exp to pm.math.exp. Didn't find a pm.math equivalent for at.extra_ops.diff.

View entire conversation on ReviewNB

Done

View entire conversation on ReviewNB

Updated the text to remove the explanation.

View entire conversation on ReviewNB

Thanks @cuchoi!