Probabilistic Matrix Factorization for Making Personalized Recommendations to v4 #365
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
suggestion to consider... add |
|
If the conflicts can be resolved, and the suggested tags added, then this is probably done? |
|
Indeed, that should be done. |
So it's saying that there are conflicts which need to be resolve before this can be approved and merged. But it's a bit strange because the conflicting files are the ones being updated. Any insights @OriolAbril? |
|
Let me just re-run it to finish the NB and add the tag.
…Sent from my iPhone
On 11 Jun 2022, at 18:29, Benjamin T. Vincent ***@***.***> wrote:
@drbenvincent approved this pull request.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.
|
|
View / edit / reply to this conversation on ReviewNB drbenvincent commented on 2022-06-12T10:01:52Z Could remove |
|
View / edit / reply to this conversation on ReviewNB drbenvincent commented on 2022-06-12T10:01:52Z Line #1. %autoreload 2 This can be removed I believe |
|
View / edit / reply to this conversation on ReviewNB drbenvincent commented on 2022-06-12T10:01:53Z Line #2. %matplotlib inline Not sure we still need this? |
|
I think this is ready. But it won't let me merge until the conflicts are resolved. I'm a bit confused as it is the particular files that are being changed which are conflicting, and I thought this was the point. Any insights @percevalve or @OriolAbril ? |
|
Looks like I solve the conflict, but the version is not the latest run... running it now. |
percevalve
force-pushed
the
probabilistic_matrix_factorization
branch
from
7c3bd6e to
7f0ad01
Compare
Moving to v4 of Probabilistic Matrix Factorization for Making Personalized Recommendations
Related Issue: #58
Also remove the default to one chain in
draw_samples(kwargs.setdefault("chains", 1))Helpful links