Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PULL_REQUEST_TEMPLATE.md #233

Merged
merged 6 commits into from
Oct 13, 2021
Merged

Update PULL_REQUEST_TEMPLATE.md #233

merged 6 commits into from
Oct 13, 2021

Conversation

canyon289
Copy link
Member

@canyon289 canyon289 commented Oct 3, 2021

Updated pr template to what you see below. Feel free to modify directly, or tell me to change things or whatever

{Insert Description}

Helpful links

Copy link
Member

@OriolAbril OriolAbril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we keep a checklist item pointing to the relevant tracker issue? It has been a great help to have everything in https://github.com/pymc-devs/pymc-examples/projects/1 and I think it will still be extremely helpful with the rerunning+updating to pymc 4.0 so I think we should keep if for now and continue to open tracker issues for new notebooks

also link to style guide should be https://github.com/pymc-devs/pymc/wiki/PyMC-Jupyter-Notebook-Style-Guide not to pr template

@canyon289
Copy link
Member Author

Updated link, In regards to tracker we can add it to checklist but can non maintainers edit that tracker? Or should the item say "ask a maintainer to add a card before merge?"

@OriolAbril
Copy link
Member

OriolAbril commented Oct 4, 2021

I want a checklist iitem that says "related to issue #xxx". There should be no PRs with no link to an issue (either tracker one or proposal one) unless they are part of the team. Then us maintainers have to create the tracker issue or go on the issue if already existent and update its position in the project (I don't know if it's possible to do automatically but if it is I don't know how) but it's much easier to do if the issue is linked. And doing this also leaves the "update history" of the notebook in the tracker, i.e. #81

In the near future, updates will be much more common than new notebooks, and it should be kept this way going forward too, otherwise the notebooks will get out of touch again.

@canyon289
Copy link
Member Author

That totally makes sense, thanks for clarifying. I'll add it

@OriolAbril OriolAbril merged commit d1bf72a into main Oct 13, 2021
@OriolAbril OriolAbril deleted the pr_template_update branch October 13, 2021 04:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants