Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Problems in (high impact) GLM Hierarchical notebook #421

Open
cluhmann opened this issue Sep 15, 2022 · 3 comments
Open

Problems in (high impact) GLM Hierarchical notebook #421

cluhmann opened this issue Sep 15, 2022 · 3 comments
Labels
good first issue Good for newcomers high impact Notebooks with most visits on docs.pymc.io

Comments

@cluhmann
Copy link
Member

Notebook title:GLM: Hierarchical Linear Regression
Notebook url: source link, website link

Issue description

There are many, many divergences in the sample of the main, hierarchical model. There also appear to be images missing under "The Models" section. Not sure what these are supposed to be.

Proposed solution

I suspect the sampling could be fixed by re-running and/or setting the random seed for stability. Not sure what the images were (at one time).
@cluhmann cluhmann added good first issue Good for newcomers high impact Notebooks with most visits on docs.pymc.io labels Sep 15, 2022
@cluhmann cluhmann changed the title Problems in (high profile) GLM Hierarchical notebook Problems in (high impact) GLM Hierarchical notebook Sep 15, 2022
@OriolAbril
Copy link
Member

Maybe we can remove/deprecate it in favour of https://www.pymc.io/projects/examples/en/latest/case_studies/multilevel_modeling.html? Or probably better combine/restructure the two to link between them to make them complementary and avoid duplication.

cc @fonnesbeck who I know was thinking about improving the multilevel modeling primer one.

@fonnesbeck
Copy link
Member

Yes, there are a few things about the current version of the multilevel modeling primer I don't like (notably the expression of floor and basement as being independent). There is significant overlap in content with this notebook, so I'd be in favor of somehow merging them. If I'm not mistaken, this notebook originally used the now-extinct glm submodule, which made it stand out a little more. As far as the sampling issues go, I'd bet they are related to the centered random effect parameterization.

@reshamas reshamas mentioned this issue Sep 29, 2022
Merged
3 tasks
@fonnesbeck
Copy link
Member

UPDATE: Will be aiming to complete this in the next few days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers high impact Notebooks with most visits on docs.pymc.io
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@fonnesbeck @OriolAbril @cluhmann