Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop support for legacy Python 3.4 #289

Merged
merged 2 commits into from
Dec 29, 2018
Merged

Drop support for legacy Python 3.4 #289

merged 2 commits into from
Dec 29, 2018

Conversation

hugovk
Copy link
Member

@hugovk hugovk commented Nov 27, 2018

Changes proposed in this pull request:

  • It's not long until Python 3.4's EOL on 2019-03-16
  • Python 3.4 isn't used much
  • A backwards-incompatible release is coming up soon (dropping Python 2 Drop support for legacy Python 2 #281) so it's a good time to bundle this into a major version release
  • Upgrade Python syntax with pyupgrade `find . -name "*.py"` --py3-plus
  • Includes PR Drop support for legacy Python 2 #281 to avoid merge conflicts

Here's the pip installs for pylast from PyPI for last month:

category percent downloads
2.7 41.59% 2,123
3.6 36.85% 1,881
3.5 8.85% 452
null 5.99% 306
3.7 5.80% 296
3.4 0.82% 42
3.3 0.10% 5
Total 5,105

Source: pypistats python_minor --last-month pylast

image

https://github.com/hugovk/pypi-tools#examples

@hugovk hugovk mentioned this pull request Nov 27, 2018
Closed
@hugovk hugovk added enhancement New feature or request backwards incompatible labels Nov 27, 2018
@codecov
Copy link

codecov bot commented Nov 27, 2018 •
edited
Loading

Codecov Report

Merging #289 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #289   +/-   ##
=======================================
  Coverage   95.39%   95.39%           
=======================================
  Files           2        2           
  Lines        1215     1215           
=======================================
  Hits         1159     1159           
  Misses         56       56
Impacted Files Coverage Δ
pylast/__init__.py 95.38% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 53806b0...ee879aa. Read the comment docs.

@hugovk
Copy link
Member Author

hugovk commented Nov 27, 2018

As #281:

Coverage dropped because some covered lines were removed and also the new fail-early code isn't tested on Python 2.

@hugovk hugovk merged commit 718fba0 into master Dec 29, 2018
@hugovk hugovk deleted the rm-2-3.4 branch December 29, 2018 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
backwards incompatible enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@hugovk