Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I believe recent changes (#48) have broken x86 compilation. The current bindings are currently setting a special case for
x86
targets, replacingsize_t
byusize
when generating the bindings:ort/build.rs
Line 660 in 254a5ce
ort/src/bindings/linux/x86_64/bindings.rs
Line 376 in 254a5ce
This means that
sys::OrtROCMProviderOptions
expects ausize
for thegpu_mem_limit
field rather than ac_ulong
. The current code does not compile with the following error message:This PR handles the special
x86
architecture case, and should hopefully maintain M1 mac compatibility from the previous PR.This could also be fixed by casting into the expected type with:
Please let me know what your preferred solution would be, happy to amend the change request