Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ 💉 Update docs and automate doctests #291

Merged
merged 20 commits into from
Feb 13, 2021
Merged

♻️ 💉 Update docs and automate doctests #291

merged 20 commits into from
Feb 13, 2021

Conversation

cthoyt
Copy link
Member

@cthoyt cthoyt commented Feb 12, 2021

This PR does the following:

  • Make sure more modules are automagically generated
  • Add doctests to tutorials
  • Update license year
  • Update acknowledgements and author list
  • Update typing in dataset to make sure it's possible to run the pipeline() on just a testing/training dataset

This PR supersedes #241 from @sbonner0. I'm sorry we never got around to figuring out the issue with GitHub actions, so I will include your name in this PR so you are credited with pointing out the original issue and providing the solution.

@cthoyt cthoyt changed the title Update docs ♻️ 💉 Update docs and automate doctests Feb 12, 2021
@sbonner0
Copy link
Contributor

No problem - thanks for remembering and tagging me. Shall I remove the other PR?

@cthoyt
Copy link
Member Author

cthoyt commented Feb 12, 2021

@sbonner0 I'll take care of that after this one is merged :)

cthoyt and others added 10 commits February 12, 2021 16:59
Add link to GitHub authors

Trigger CI
Co-Authored-By: Stephen Bonner <10208489+sbonner0@users.noreply.github.com>
Trigger CI

Co-Authored-By: Stephen Bonner <10208489+sbonner0@users.noreply.github.com>
Trigger CI

Co-Authored-By: Stephen Bonner <10208489+sbonner0@users.noreply.github.com>
@cthoyt cthoyt requested review from mberr and mali-git February 12, 2021 19:57
@cthoyt cthoyt marked this pull request as ready for review February 12, 2021 19:58
@cthoyt
Copy link
Member Author

cthoyt commented Feb 12, 2021

oooof I just saw the logging and it does not look good.

@cthoyt
Copy link
Member Author

cthoyt commented Feb 12, 2021

@PyKEEN-bot test

@cthoyt cthoyt merged commit ad449ec into master Feb 13, 2021
@cthoyt
Copy link
Member Author

cthoyt commented Feb 13, 2021

@mberr @mali-git there weren't really any things that needed review in this PR so I just merged it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants