Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🔧✍️ Fix CachedTextRepresentation.from_dataset #1259

Merged
merged 7 commits into from
Apr 16, 2023
Merged

🔧✍️ Fix CachedTextRepresentation.from_dataset #1259

merged 7 commits into from
Apr 16, 2023

Conversation

mberr
Copy link
Member

@mberr mberr commented Apr 15, 2023

Fix #1243

Replace #1244

@mberr mberr marked this pull request as ready for review April 15, 2023 14:28
@mberr mberr mentioned this pull request Apr 15, 2023
Closed
cthoyt
cthoyt approved these changes Apr 15, 2023
View reviewed changes
Copy link
Member

@cthoyt cthoyt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything is good except the annotation on cache - should be compatible with old python versions and use Optional[TextCache]

@mberr
Copy link
Member Author

mberr commented Apr 16, 2023

Everything is good except the annotation on cache - should be compatible with old python versions and use Optional[TextCache]

The file contains already an

pykeen/src/pykeen/nn/representation.py

Line 5 in 3f8d0e2

from __future__ import annotations

so this should work in older versions, too.

@mberr mberr merged commit 746cbe0 into master Apr 16, 2023
@mberr mberr deleted the fix-text-representation-2 branch April 16, 2023 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cthoyt cthoyt cthoyt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

WikidataTextRepresentation example code not working
2 participants
@mberr @cthoyt