Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sync with dev branch and unit test for the PR #214 #217

Merged
merged 1 commit into from
Jul 31, 2020
Merged

Sync with dev branch and unit test for the PR #214 #217

merged 1 commit into from
Jul 31, 2020

Conversation

mathsyouth
Copy link
Contributor

@mathsyouth mathsyouth commented Jul 31, 2020 •
edited
Loading

Add unit tests and update the change log for the PR #214

With your PR, here is a check list:

  • Has Test cases written
  • Has all code lines tested
  • Has make format been run?
  • Has moban been run?
  • Passes all Travis CI builds
  • Has fair amount of documentation if your change is complex
  • run 'make format' so as to confirm the pyexcel organisation's coding style
  • Please update CHANGELOG.rst
  • Please add yourself to CONTRIBUTORS.rst
  • Agree on NEW BSD License for your contribution

@mathsyouth
Sync with dev branch and unit test for the PR pyexcel#214
6eddb17 
Add unit tests and update the change log for the PR pyexcel#214
@codecov-commenter
Copy link

codecov-commenter commented Jul 31, 2020 •
edited
Loading

Codecov Report

Merging #217 into dev will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #217      +/-   ##
==========================================
+ Coverage   98.30%   98.34%   +0.03%     
==========================================
  Files         102      102              
  Lines        6559     6711     +152     
==========================================
+ Hits         6448     6600     +152     
  Misses        111      111
Impacted Files Coverage Δ
pyexcel/_compact.py 94.28% <100.00%> (ø)
pyexcel/book.py 98.42% <100.00%> (ø)
pyexcel/core.py 100.00% <100.00%> (ø)
pyexcel/internal/attributes.py 95.23% <100.00%> (ø)
pyexcel/internal/garbagecollector.py 100.00% <100.00%> (ø)
pyexcel/internal/meta.py 95.23% <100.00%> (+0.11%) ⬆️
pyexcel/internal/sheets/column.py 97.61% <100.00%> (ø)
pyexcel/internal/sheets/formatters.py 94.52% <100.00%> (ø)
pyexcel/internal/sheets/matrix.py 98.48% <100.00%> (ø)
pyexcel/internal/sheets/row.py 95.41% <100.00%> (ø)
... and 46 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d67e72...6eddb17. Read the comment docs.

@mathsyouth mathsyouth mentioned this pull request Jul 31, 2020
Closed
10 tasks
@mathsyouth
Copy link
Contributor Author

I didn't find CONTRIBUTORS.rst, so I don't know how to add myself to contributors list.

@chfw
Copy link
Member

chfw commented Jul 31, 2020

@mathsyouth , Apologies! I have not even included one. Let me do it.

I had contributors.rst for other open source projects of mine.

@chfw chfw merged commit 89dde7c into pyexcel:dev Jul 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mathsyouth @codecov-commenter @chfw