remove leading and trailing whitespace for names #214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The names will be used as keys for returned dictionary. If keys are not striped and user inputs striped keys because excel shows unseen whitespace, it will cause a error.
|
thanks! it makes sense. |
|
would you like to make a unit test to protect your modification? i.e.: just in case I accidentally would remove your improvement in the future. |
|
I want to make a unit test for the modification. However, after installing dependent libraries according to Developer's guide, I launched your tests like this: |
|
@mathsyouth could you please have a look again? it has been fixed. |
|
Please update change log for your PR too. |
10 tasks
mathsyouth
added a commit
to mathsyouth/pyexcel
that referenced
this pull request
Jul 31, 2020
Add unit tests and update the change log for the PR pyexcel#214
10 tasks
chfw
pushed a commit
that referenced
this pull request
Jul 31, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The names will be used as keys for returned dictionary. If keys are not
striped and user inputs striped keys because excel shows unseen
whitespace, it will cause an error.