Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix :latest #2599

Merged
merged 7 commits into from
Jan 22, 2023
Merged

Fix :latest #2599

merged 7 commits into from
Jan 22, 2023

Conversation

native-api
Copy link
Member

@native-api native-api commented Jan 22, 2023

Make sure you have checked all steps below.

Prerequisite

  • Please consider implementing the feature as a hook script or plugin as a first step.
    • pyenv has some powerful support for plugins and hook scripts. Please refer to Authoring plugins for details and try to implement it as a plugin if possible.
  • Please consider contributing the patch upstream to rbenv, since we have borrowed most of the code from that project.
    • We occasionally import the changes from rbenv. In general, you can expect changes made in rbenv will be imported to pyenv too, eventually.
    • Generally speaking, we prefer not to make changes in the core in order to keep compatibility with rbenv.
  • My PR addresses the following pyenv issue (if any)

Description

  • Here are some details about my PR

#2568 inadvertently broke :latest due to changed logic.
Tests passed because there was no test for :latest.

Tests

  • My PR adds the following unit tests (if any)

Test for :latest.
Note that other tests disable hooks. We enable only Pyenv built-in ones for this particular test.

@native-api native-api changed the title Fix :latest after #2568 Fix :latest after #2568 Jan 22, 2023
@native-api native-api merged commit f1a1f59 into pyenv:master Jan 22, 2023
@native-api native-api deleted the python_build_latest branch January 22, 2023 02:49
@rockandska
Copy link
Contributor

rockandska commented Jan 25, 2023

sorry to forgot about this @native-api

Edit: in #2569 , the problem was with 2.3.9, but #2568 was merge after and release in 2.3.10

@native-api
Copy link
Member Author

That's okay @rockandska . As I said, the reason this slipped through is because we had no unit test for :latest.

@native-api native-api changed the title Fix :latest after #2568 Fix :latest Jan 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2.3.9 Regression in pyenv-latest
2 participants