Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG] Update data dicts to 2024d #2157

Merged
merged 5 commits into from
Nov 8, 2024

Conversation

aaronzs
Copy link
Contributor

@aaronzs aaronzs commented Oct 14, 2024

Describe the changes

JPEG XL image compression was added to DICOM standard recently.

This PR updates Transfer Syntax UIDs for JPEG XL data dicts to DICOM 2024d. src/pydicom/_uid_dict.py was generated by util/generate_dict/generate_uid_dict.py. and I kept the lines related to JPEG XL

New UID constants have been added:

  • JPEGXLLossless
  • JPEGXLJPEGRecompression
  • JPEGXL
  • ThermographyImageStorage
  • ThermographyMultiFrameImageStorage
  • LabelMapSegmentationStorage
  • HeightMapSegmentationStorage

Docs preview link: https://output.circle-artifacts.com/output/job/753dbc63-2411-4dd0-8a1e-b01c79644eb8/artifacts/0/doc/_build/html/index.html

Tasks

  • Unit tests added that reproduce the issue or prove feature is working
  • Fix or feature added
  • Code typed and mypy shows no errors
  • Documentation updated (if relevant)
    • No warnings during build
    • Preview link (CircleCI -> Artifacts -> doc/_build/html/index.html)
  • Unit tests passing and overall coverage the same or better

Copy link

codecov bot commented Oct 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.39%. Comparing base (1ea7015) to head (a52c2aa).
Report is 8 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2157      +/-   ##
==========================================
+ Coverage   98.34%   98.39%   +0.04%     
==========================================
  Files          77       77              
  Lines       13515    13537      +22     
==========================================
+ Hits        13292    13320      +28     
+ Misses        223      217       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@scaramallion
Copy link
Member

I kept the lines related to JPEG XL

Were there other new UIDs as well? Could you also add an entry to the release notes?

Relevant

@aaronzs
Copy link
Contributor Author

aaronzs commented Oct 15, 2024

Were there other new UIDs as well? Could you also add an entry to the release notes?

There are 4 more SOP Classes added to UID_dictionary. I'll rename this PR to "Update data dicts to 2024d".

@scaramallion

@aaronzs aaronzs changed the title [MRG] Add JPEG XL transfer syntaxes [WIP] Update data dicts to 2024d Oct 15, 2024
@aaronzs aaronzs changed the title [WIP] Update data dicts to 2024d [MRG] Update data dicts to 2024d Oct 15, 2024
@aaronzs
Copy link
Contributor Author

aaronzs commented Oct 15, 2024

@scaramallion This PR is ready for review.

@scaramallion scaramallion merged commit 80cec11 into pydicom:main Nov 8, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants