[MRG] Catch missed test warnings, clean up validation warnings with DSdecimal #2107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2107 +/- ##
==========================================
+ Coverage 98.32% 98.36% +0.03%
==========================================
Files 76 76
Lines 13362 13362
==========================================
+ Hits 13138 13143 +5
+ Misses 224 219 -5 ☔ View full report in Codecov by Sentry. |
scaramallion
changed the title
mrbean-bremen
approved these changes
Jul 21, 2024
| @@ -1108,7 +1108,7 @@ def __str__(self) -> str: | |||
| return repr(self)[1:-1] | |||
|
|
|||
| def __repr__(self) -> str: | |||
| if self.auto_format and hasattr(self, "original_string"): | |||
There was a problem hiding this comment.
I actually don't understand in what situations autoformat is needed.
There was a problem hiding this comment.
It's a bit of an odd thing, you'd only be able to use it if creating your own values, in which case you'd presumably just format them correctly beforehand?
There was a problem hiding this comment.
Yes, that's what I've thought, too... Maybe @darcymason knows more?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the changes
original_stringvalue with DSdecimal if auto_format is False... it was flagging DSdecimal("1.2345") as invalid.The validation warnings with IS/DS are a bit messy. I think either the validation should be done externally by the validation checks in
valuerep, or internally by the class__init__. Currently it's both, so you can get two warnings about the same invalid value.Tasks