Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "MNT: prepare h5netcdf backend for (coming) change in dimension handling" #6208

Closed
wants to merge 1 commit into from

Conversation

mathause
Copy link
Collaborator

Reverts #6200

@TomNicholas
Copy link
Member

I don't really understand which line of this caused the packaging problem, but please revert what you need to to fix xarray main! We can just keep releasing new minor versions until we get it right, don't worry about that.

@mathause
Copy link
Collaborator Author

Did the tests run? Close/ reopen.

@mathause mathause closed this Jan 29, 2022
@mathause mathause reopened this Jan 29, 2022
@s-weigand
Copy link
Contributor

s-weigand commented Jan 29, 2022

This didn't cause the packaging issue, the packaging issue was caused by #6096 and the good old "Wait this isn't a python builtin, but I have it in each environment!"
Like pkg_resources which comes with setuptools, took me ages to find what was wrong back then (old setuptools version in that venv) 😅

@s-weigand
Copy link
Contributor

Looks like the same error was there two days ago so it isn't dask 2022.01.1 since it only got released 16h ago

@kmuehlbauer
Copy link
Contributor

kmuehlbauer commented Jan 29, 2022

That was an upstream-dev build, so it could still be a dask issue.

@mathause
Copy link
Collaborator Author

I am closing this because it was not the issue of the test failure you saw in #6207.

@mathause mathause closed this Jan 29, 2022
@mathause mathause deleted the revert-6200-h5netcdf-devel-fixes branch January 29, 2022 13:20
@s-weigand
Copy link
Contributor

That was an upstream-dev build, so it could still be a dask issue.

Ahhh I should have looked more closely.

Btw I installed an older dask version (conda install -c conda-forge dask-core=2022.1.0) and tests pass.
So I guess it is an issue with dask 2022.01.1.

@kmuehlbauer
Copy link
Contributor

At least it helps to narrow down the time when this appeared in dask. AFAICT the first occurrence was in the nightly upstream-dev build #6197.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants