Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Ruff 0.4.8 #9585

Merged
merged 6 commits into from
Jun 7, 2024
Merged

Update to Ruff 0.4.8 #9585

merged 6 commits into from
Jun 7, 2024

Conversation

Viicos
Copy link
Member

@Viicos Viicos commented Jun 6, 2024

Change Summary

Related issue number

Checklist

  • The pull request title is a good summary of the changes - it will be used in the changelog
  • Unit tests for the changes exist
  • Tests pass on CI
  • Documentation reflects the changes where applicable
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

@github-actions github-actions bot added the relnotes-fix Used for bugfixes. label Jun 6, 2024
Copy link

codspeed-hq bot commented Jun 6, 2024

CodSpeed Performance Report

Merging #9585 will not alter performance

Comparing Viicos:ruff-0-4-8 (cd1f8c7) with main (218388b)

Summary

✅ 13 untouched benchmarks

Copy link
Member

@sydney-runkle sydney-runkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just looked through all of the files - changes look great, thanks @Viicos!

We'll want to get the mypy tests back to passing though, so might have to revert those changes...

@sydney-runkle
Copy link
Member

Once we get those back to passing, I'll approve :).

@sydney-runkle sydney-runkle added the awaiting author response awaiting response from issue opener label Jun 6, 2024
@sydney-runkle
Copy link
Member

Ah ok so the annoying thing with these is that we have to run the mypy tests locally and match up the output files with the newly formatted input files. I'll do that and push shortly :).

@sydney-runkle
Copy link
Member

For some reason I can't repro the linting failures locally...

@sydney-runkle
Copy link
Member

Chatted with @dmontagu,

I believe all of the mypy output files that have been removed are not necessary - these changes were applied by rerunning all of the mypy tests locally with help from the make commands.

@sydney-runkle sydney-runkle enabled auto-merge (squash) June 7, 2024 02:14
@sydney-runkle sydney-runkle merged commit 332e77b into pydantic:main Jun 7, 2024
51 checks passed
@Viicos Viicos deleted the ruff-0-4-8 branch June 7, 2024 07:18
@Viicos
Copy link
Member Author

Viicos commented Jun 7, 2024

@sydney-runkle thanks for finishing this one!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting author response awaiting response from issue opener relnotes-fix Used for bugfixes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants