Use Self where possible
#9479
Merged
Use Self where possible
#9479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodSpeed Performance ReportMerging #9479 will not alter performanceComparing Summary
|
|
Please review |
|
Is this one intended to be a breaking change ? |
vikyw89
reviewed
Jul 16, 2024
| if resolved_bases is not __base__: | ||
| ns['__orig_bases__'] = __base__ | ||
| namespace.update(ns) | ||
|
|
||
| return meta( | ||
| __model_name, | ||
| model_name, |
There was a problem hiding this comment.
this one is breaking backwards compatibility
vikyw89
reviewed
Jul 16, 2024
| def create_model( | ||
| __model_name: str, | ||
| model_name: str, |
There was a problem hiding this comment.
this one is breaking backwards compatibility
1 task
|
@vikyw89 You can read more about it here: https://typing.readthedocs.io/en/latest/spec/historical.html#positional-only-parameters. It is technically a breaking change, although using |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Related issue number
Checklist
Selected Reviewer: @davidhewitt