Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use PEP570 syntax #8940

Merged
merged 3 commits into from
Mar 5, 2024
Merged

Use PEP570 syntax #8940

merged 3 commits into from
Mar 5, 2024

Conversation

Viicos
Copy link
Member

@Viicos Viicos commented Mar 4, 2024

Only the non deprecated stuff was touched, and last commit is a small fix that removes the need for a type ignore

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Mar 4, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #8940 will not alter performance

Comparing Viicos:pep570 (131b3c2) with main (acf684a)

Summary

✅ 10 untouched benchmarks

sydney-runkle
sydney-runkle approved these changes Mar 5, 2024
View reviewed changes
Copy link
Member

@sydney-runkle sydney-runkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Left one comment about a variable that I think we should probably rename.

Thanks for your awesome work on this!!

pydantic/type_adapter.py Outdated Show resolved Hide resolved
@sydney-runkle sydney-runkle added the relnotes-change Used for changes to existing functionality which don't have a better categorization. label Mar 5, 2024
@sydney-runkle
Copy link
Member

I think relnotes-change is a bit of a strong label here, but I don't think relnotes-fix makes sense...

@sydney-runkle sydney-runkle enabled auto-merge (squash) March 5, 2024 14:16
@sydney-runkle
Copy link
Member

@Viicos,

If you're interested in contributing to pydantic-core at all, we could stand to use PEP570 syntax over there as well!

@sydney-runkle sydney-runkle merged commit b09e06c into pydantic:main Mar 5, 2024
52 checks passed
@Viicos Viicos deleted the pep570 branch March 5, 2024 14:37
@Viicos
Copy link
Member Author

Viicos commented Mar 5, 2024

Yes I was thinking about doing the same there, will land a PR in a couple hours

@Viicos
Copy link
Member Author

Viicos commented Mar 5, 2024

@sydney-runkle: pydantic/pydantic-core#1216

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sydney-runkle sydney-runkle sydney-runkle approved these changes

Assignees
No one assigned
Labels
relnotes-change Used for changes to existing functionality which don't have a better categorization.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Viicos @sydney-runkle