Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add BaseModel.model_validate_strings and TypeAdapter.validate_strings #7552

Merged
merged 2 commits into from
Sep 22, 2023

Conversation

hramezani
Copy link
Member

@hramezani hramezani commented Sep 21, 2023

validate_strings was implemented in pydantic-core in pydantic/pydantic-core#883.

closes #7549
closes #7065

Selected Reviewer: @adriangb

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Sep 21, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 5a5d690
Status: ✅  Deploy successful!
Preview URL: https://2b13f019.pydantic-docs2.pages.dev
Branch Preview URL: https://validate-strings.pydantic-docs2.pages.dev

View logs

@hramezani
Copy link
Member Author

Please review

Copy link
Member

@samuelcolvin samuelcolvin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, we could add tests for RootModel too.

please update (just to reassign).

@pydantic-hooky pydantic-hooky bot added awaiting author revision awaiting changes from the PR author and removed ready for review labels Sep 21, 2023
@pydantic-hooky pydantic-hooky bot assigned hramezani and unassigned samuelcolvin Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting author revision awaiting changes from the PR author relnotes-feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New feature: validate_strings Coercion from datetime at midnight to date is incompatible with JSON schema
3 participants